Skip to content

Conversation

@Julian048
Copy link
Contributor

@Julian048 Julian048 commented Aug 11, 2023

@Julian048
Copy link
Contributor Author

As per #50818 the scatter_matrix function would not produce a scatter matrix with a grid if grid=True was passed. I found this to be a result of the act of setting all non-bottom/left corner subplots of the matrix to have their axes hidden. The matplotlib function 'grid()' would simply not work on subplots that had their axes hidden.

To get around this instead of hiding the x and y axes I found that turning off labels and tick numbers accomplishes the same goal of hiding unnecessary information while allowing grid lines to be shown when grid() is called. Heres what it looks like

Screenshot 2023-08-11 at 12 14 20 PM

If its preferred to give grid lines to diagonals thats a fix I can make as well. I thought turning them off would be better as the tick numbers for the diagonal is incorrect, though thats unrelated to the grid lines.

@mroeschke mroeschke added the Visualization plotting label Aug 11, 2023
@Julian048 Julian048 changed the title Scatter matrix grid Fix scatter_matrix lacking ability to use grid parameter Aug 11, 2023
@Julian048
Copy link
Contributor Author

@mroeschke could you provide any assistance on next steps?

@mroeschke
Copy link
Member

I nor many people have much expertise on this part of the code base so I'm not sure if anyone is available to provide meaningful feedback on the fix

@mroeschke
Copy link
Member

Thanks for the PR here, but as mentioned, I don't think we have anyone on the core team right now to provide meaningful feedback here so closing for now. We can reopen if we have a matplotlib expert to review this PR

@mroeschke mroeschke closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: "grid" parameter is ignored by scatter_matrix function

2 participants